Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ticket/289] Removed duplicated code from attachments.php

Browse Source
This commit is contained in:
Marc Alexander
2014-07-24 09:12:18 +02:00
parent 8479cb28ca
commit 53a58f8a7c
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
modules/attachments.php
View File

@@ -167,6 +167,8 @@ class attachments extends module_base
*/ */
public function select_filetype($value, $key, $module_id) public function select_filetype($value, $key, $module_id)
{ {
$extensions = array();
// Get extensions // Get extensions
$sql = 'SELECT * $sql = 'SELECT *
FROM ' . EXTENSIONS_TABLE . ' FROM ' . EXTENSIONS_TABLE . '
@@ -178,11 +180,7 @@ class attachments extends module_base
$extensions[] = $row; $extensions[] = $row;
} }
$selected = array(); $selected = $this->get_selected_filetypes($module_id);
if(isset($this->config['board3_attachments_filetype_' . $module_id]) && strlen($this->config['board3_attachments_filetype_' . $module_id]) > 0)
{
$selected = explode(',', $this->config['board3_attachments_filetype_' . $module_id]);
}
// Build options // Build options
$ext_options = '<select id="' . $key . '" name="' . $key . '[]" multiple="multiple">'; $ext_options = '<select id="' . $key . '" name="' . $key . '[]" multiple="multiple">';
@@ -276,10 +274,7 @@ class attachments extends module_base
$filetypes = array(); $filetypes = array();
// Get filetypes and put them into an array // Get filetypes and put them into an array
if(isset($this->config['board3_attachments_filetype_' . $module_id]) && strlen($this->config['board3_attachments_filetype_' . $module_id]) > 0) $filetypes = $this->get_selected_filetypes($module_id);
{
$filetypes = explode(',', $this->config['board3_attachments_filetype_' . $module_id]);
}
if($this->config['board3_attachments_forum_ids_' . $module_id] !== '') if($this->config['board3_attachments_forum_ids_' . $module_id] !== '')
{ {
@@ -368,4 +363,22 @@ class attachments extends module_base
return 'attachments_' . $type . '.html'; return 'attachments_' . $type . '.html';
} }
/**
* Get the filetypes that were selected in the ACP
*
* @param int $module_id Module ID
*
* @return array An array with the selected filetypes
*/
protected function get_selected_filetypes($module_id)
{
$selected = array();
if(isset($this->config['board3_attachments_filetype_' . $module_id]) && strlen($this->config['board3_attachments_filetype_' . $module_id]) > 0)
{
$selected = explode(',', $this->config['board3_attachments_filetype_' . $module_id]);
}
return $selected;
}
} }