Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Get rid of magic numbers in portal.php

Browse Source
This commit is contained in:
Marc Alexander
2012-02-26 13:00:22 +01:00
parent 2e95c0f6ee
commit 9e542e181d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
root/portal.php
View File

@@ -92,30 +92,30 @@ foreach ($portal_modules as $row)
{ {
$user->add_lang('mods/portal/' . $module->language); $user->add_lang('mods/portal/' . $module->language);
} }
if ($row['module_column'] == 1 && $config['board3_left_column']) if ($row['module_column'] == column_string_num('left') && $config['board3_left_column'])
{ {
$template_module = $module->get_template_side($row['module_id']); $template_module = $module->get_template_side($row['module_id']);
$template_column = 'left'; $template_column = 'left';
++$module_count['left']; ++$module_count['left'];
} }
if ($row['module_column'] == 2) if ($row['module_column'] == column_string_num('center'))
{ {
$template_module = $module->get_template_center($row['module_id']); $template_module = $module->get_template_center($row['module_id']);
$template_column = 'center'; $template_column = 'center';
++$module_count['center']; ++$module_count['center'];
} }
if ($row['module_column'] == 3 && $config['board3_right_column']) if ($row['module_column'] == column_string_num('right') && $config['board3_right_column'])
{ {
$template_module = $module->get_template_side($row['module_id']); $template_module = $module->get_template_side($row['module_id']);
$template_column = 'right'; $template_column = 'right';
++$module_count['right']; ++$module_count['right'];
} }
if ($row['module_column'] == 4) if ($row['module_column'] == column_string_num('top'))
{ {
$template_module = $module->get_template_center($row['module_id']); $template_module = $module->get_template_center($row['module_id']);
++$module_count['top']; ++$module_count['top'];
} }
if ($row['module_column'] == 5) if ($row['module_column'] == column_string_num('bottom'))
{ {
$template_module = $module->get_template_center($row['module_id']); $template_module = $module->get_template_center($row['module_id']);
++$module_count['bottom']; ++$module_count['bottom'];