Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ticket/715] Resolve code sniffer complaints

Browse Source 
B3P-715
This commit is contained in:
Marc Alexander
2021-08-28 08:36:22 +02:00
parent 2c89b28a53
commit d8bb1c64a4
3 changed files with 41 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
portal/modules/constraints_handler.php
View File

@@ -10,13 +10,14 @@
namespace board3\portal\portal\modules; namespace board3\portal\portal\modules;
use board3\portal\portal\columns; use board3\portal\portal\columns;
use phpbb\user;
class constraints_handler class constraints_handler
{ {
/** @var \board3\portal\portal\columns */ /** @var columns */
protected $portal_columns; protected $portal_columns;
/** @var \phpbb\user */ /** @var user */
protected $user; protected $user;
/** @var string Form action (link) */ /** @var string Form action (link) */
@@ -29,7 +30,7 @@ class constraints_handler
* Constructor for constraints handler * Constructor for constraints handler
* *
* @param columns $portal_columns Portal columns * @param columns $portal_columns Portal columns
* @param \phpbb\user $user phpBB user object * @param user $user phpBB user object
*/ */
public function __construct(columns $portal_columns, $user) public function __construct(columns $portal_columns, $user)
{ {

4
portal/modules/database_handler.php
View File

@@ -28,13 +28,13 @@ class database_handler
/** @var int Board3 module enabled */ /** @var int Board3 module enabled */
const B3_MODULE_ENABLED = 1; const B3_MODULE_ENABLED = 1;
/** @var \phpbb\db\driver\driver_interface */ /** @var driver_interface */
protected $db; protected $db;
/** /**
* Constructor for modules manager * Constructor for modules manager
* *
* @param \phpbb\db\driver\driver_interface $db Database driver * @param driver_interface $db Database driver
*/ */
public function __construct(driver_interface $db) public function __construct(driver_interface $db)
{ {

57
portal/modules/manager.php
View File

@@ -9,42 +9,45 @@
namespace board3\portal\portal\modules; namespace board3\portal\portal\modules;
use board3\portal\controller\helper as b3p_controller_helper;
use board3\portal\includes\helper; use board3\portal\includes\helper;
use board3\portal\modules\module_interface; use board3\portal\modules\module_interface;
use board3\portal\portal\columns; use board3\portal\portal\columns;
use phpbb\cache\service;
use phpbb\db\driver\driver_interface; use phpbb\db\driver\driver_interface;
use phpbb\request\request_interface; use phpbb\request\request_interface;
use phpbb\user;
class manager class manager
{ {
/** @var \phpbb\cache\service */ /** @var service */
protected $cache; protected $cache;
/** @var \board3\portal\controller\helper */ /** @var b3p_controller_helper */
protected $controller_helper; protected $controller_helper;
/** @var \board3\portal\portal\columns */ /** @var columns */
protected $portal_columns; protected $portal_columns;
/** @var \board3\portal\includes\helper */ /** @var helper */
protected $portal_helper; protected $portal_helper;
/** @var \board3\portal\portal\modules\constraints_handler */ /** @var constraints_handler */
protected $constraints_handler; protected $constraints_handler;
/** @var \board3\portal\portal\modules\database_handler */ /** @var database_handler */
protected $database_handler; protected $database_handler;
/** @var \phpbb\db\driver\driver_interface */ /** @var driver_interface */
protected $db; protected $db;
/** @var \phpbb\request\request_interface */ /** @var request_interface */
protected $request; protected $request;
/** @var \phpbb\user */ /** @var user */
protected $user; protected $user;
/** @var \board3\portal\modules\module_interface */ /** @var module_interface */
protected $module; protected $module;
/** @var string u_action of acp module */ /** @var string u_action of acp module */
@@ -56,17 +59,27 @@ class manager
/** /**
* Constructor for modules manager * Constructor for modules manager
* *
* @param \phpbb\cache\service $cache phpBB cache * @param service $cache phpBB cache
* @param \phpbb\db\driver\driver_interface $db Database driver * @param driver_interface $db Database driver
* @param \board3\portal\controller\helper $controller_helper Board3 Portal controller helper * @param b3p_controller_helper $controller_helper Board3 Portal controller helper
* @param \board3\portal\portal\columns $portal_columns Portal columns helper * @param columns $portal_columns Portal columns helper
* @param \board3\portal\includes\helper $portal_helper Portal helper * @param helper $portal_helper Portal helper
* @param \board3\portal\portal\modules\constraints_handler $constraints_handler Modules constraints handler * @param constraints_handler $constraints_handler Modules constraints handler
* @param \board3\portal\portal\modules\database_handler $database_handler Modules database handler * @param database_handler $database_handler Modules database handler
* @param \phpbb\request\request_interface $request phpBB request * @param request_interface $request phpBB request
* @param \phpbb\user $user phpBB user * @param user $user phpBB user
*/ */
public function __construct($cache, driver_interface $db, \board3\portal\controller\helper $controller_helper, columns $portal_columns, helper $portal_helper, constraints_handler $constraints_handler, database_handler $database_handler, request_interface $request, $user) public function __construct(
service $cache,
driver_interface $db,
b3p_controller_helper $controller_helper,
columns $portal_columns,
helper $portal_helper,
constraints_handler
$constraints_handler,
database_handler $database_handler,
request_interface $request,
user $user)
{ {
$this->cache = $cache; $this->cache = $cache;
$this->db = $db; $this->db = $db;
@@ -84,7 +97,7 @@ class manager
* *
* @param string $u_action u_action for module * @param string $u_action u_action for module
* *
* @return \board3\portal\portal\modules\manager This class * @return manager This class
*/ */
public function set_u_action($u_action) public function set_u_action($u_action)
{ {
@@ -99,7 +112,7 @@ class manager
* *
* @param string $acp_class ACP module class * @param string $acp_class ACP module class
* *
* @return \board3\portal\portal\modules\manager This class * @return manager This class
*/ */
public function set_acp_class($acp_class) public function set_acp_class($acp_class)
{ {