Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ticket/634] Add tests for birthday_list and improve modules_helper_test

Browse Source 
B3P-634
This commit is contained in:
Marc Alexander
2015-06-23 17:56:54 +02:00
parent c3297982f7
commit f82794df11
4 changed files with 137 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
modules/birthday_list.php
View File

@@ -44,10 +44,10 @@ class birthday_list extends module_base
/** @var \phpbb\config\config */
protected $config;
/** @var \phpbb\template */
/** @var \phpbb\template\template */
protected $template;
/** @var \phpbb\db\driver */
/** @var \phpbb\db\driver\driver_interface */
protected $db;
/** @var \phpbb\user */
@@ -57,8 +57,8 @@ class birthday_list extends module_base
* Construct a birthday_list object
*
* @param \phpbb\config\config $config phpBB config
* @param \phpbb\template $template phpBB template
* @param \phpbb\db\driver $db Database driver
* @param \phpbb\template\template $template phpBB template
* @param \phpbb\db\driver\driver_interface $db Database driver
* @param \phpbb\user $user phpBB user object
*/
public function __construct($config, $template, $db, $user)
@@ -185,12 +185,8 @@ class birthday_list extends module_base
*/
public function uninstall($module_id, $db)
{
$del_config = array(
'board3_birthdays_ahead_' . $module_id,
);
$sql = 'DELETE FROM ' . CONFIG_TABLE . '
WHERE ' . $db->sql_in_set('config_name', $del_config);
return $db->sql_query($sql);
$this->config->delete('board3_birthdays_ahead_' . $module_id);
return true;
}
/**