[ticket/494] Remove SQL queries to portal_modules when changing settings

B3P-494

acp/portal_module.php

@@ -296,7 +296,7 @@ class portal_module
 						WHERE module_id = ' . (int) $module_id;
 					$this->db->sql_query($sql);
 
-					$this->cache->destroy('portal_modules');
+					$this->cache->destroy('sql', PORTAL_MODULES_TABLE);
 					$this->cache->destroy('sql', CONFIG_TABLE);
 
 					if(isset($module_name))

includes/functions.php

@@ -71,6 +71,8 @@ function set_portal_config($config_name, $config_value)
 
 /**
  * Get portal modules
+ *
+ * @return array Portal modules array
  */
 function obtain_portal_modules()
 {

portal/modules/manager.php

@@ -215,7 +215,7 @@ class manager
 			trigger_error($this->user->lang['UNABLE_TO_MOVE' . (($is_row) ? '_ROW' : '')] . adm_back_link($this->u_action));
 		}
 
-		$this->cache->destroy('portal_modules');
+		$this->cache->destroy('sql', PORTAL_MODULES_TABLE);
 
 		// Handle ajax requests
 		$this->handle_ajax_request(array('success' => true));
@@ -375,7 +375,7 @@ class manager
 			}
 		}
 
-		$this->cache->destroy('portal_modules');
+		$this->cache->destroy('sql', PORTAL_MODULES_TABLE);
 	}
 
 	/**

tests/unit/acp/move_module_test.php

@@ -64,7 +64,7 @@ class phpbb_acp_move_module_test extends \board3\portal\tests\testframework\data
 		$cache = $this->getMock('\phpbb\cache\cache', array('destroy', 'sql_exists', 'get', 'put', 'sql_load', 'sql_save'));
 		$cache->expects($this->any())
 			->method('destroy')
-			->with($this->equalTo('portal_modules'));
+			->with($this->equalTo('sql'));
 		$cache->expects($this->any())
 			->method('get')
 			->with($this->anything())

tests/unit/portal/modules_manager_confirm_box_test.php

@@ -112,7 +112,7 @@ class modules_manager_confirm_box_test extends \board3\portal\tests\testframewor
 		$this->cache = $this->getMock('\phpbb\cache\cache', array('destroy', 'sql_exists', 'get', 'put', 'purge'));
 		$this->cache->expects($this->any())
 			->method('destroy')
-			->with($this->equalTo('portal_modules'));
+			->with($this->equalTo('sql'));
 		$this->cache->expects($this->any())
 			->method('get')
 			->with($this->anything())