Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ŧicket/223] Set correct permissions to uploaded files (644)

Browse Source 
phpbb_chmod() only sets the owner permissions. As we need to set the
permissions for all users, it is not possible to use phpbb_chmod().

B3P-223
This commit is contained in:
Marc Alexander
2013-10-04 16:32:10 +02:00
parent 966f5cfa2d
commit 566762c5d2
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
root/portal/includes/functions_upload.php
View File

@@ -218,8 +218,8 @@ class portal_upload
}
else if (is_file($src . '/' . $src_entry) && !is_file($dest . '/' . $src_entry))
{
copy($src . '/' . $src_entry, $dest . '/' . $src_entry);
chmod($dest . '/' . $src_entry, 0644);
@copy($src . '/' . $src_entry, $dest . '/' . $src_entry);
@chmod($dest . '/' . $src_entry, 0644);
}
}
}
@@ -240,25 +240,25 @@ class portal_upload
if (!is_dir($dir) && is_file($dir))
{
phpbb_chmod($dir, CHMOD_ALL);
return unlink($dir);
@chmod($dir, 0644);
return @unlink($dir);
}
foreach (scandir($dir) as $item)
foreach (scandir($dir) as $item)
{
if ($item == '.' || $item == '..')
if ($item == '.' || $item == '..')
{
continue;
}
if (!$this->directory_delete($dir . "/" . $item))
if (!$this->directory_delete($dir . "/" . $item))
{
phpbb_chmod($dir . "/" . $item, CHMOD_ALL);
if (!$this->directory_delete($dir . "/" . $item))
@chmod($dir . "/" . $item, 0644);
if (!$this->directory_delete($dir . "/" . $item))
{
return false;
}
}
}
}
}
return @rmdir($dir);
}
@@ -304,18 +304,18 @@ class portal_upload
// remove old backup file first
if(file_exists($to . '.bak'))
{
phpbb_chmod($to . '.bak', CHMOD_ALL);
@chmod($to . '.bak', 0644);
unlink($to . '.bak');
}
@rename($to, $to . '.bak');
phpbb_chmod($to, CHMOD_ALL);
@chmod($to, 0644);
}
if (!@copy($from, $to))
{
return sprintf($user->lang['MODULE_COPY_FAILURE'], $to);
}
phpbb_chmod($to, CHMOD_ALL);
@chmod($to, 0644);
return true;
}
@@ -354,4 +354,4 @@ class portal_upload
}
return true;
}
}
}