Julian/phpbb_board3-portal_tlw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ticket/289] Rename mod_version_check to just version_check

Browse Source 
B3P-289
This commit is contained in:
Marc Alexander
2014-07-07 00:24:09 +02:00
parent cebf984217
commit 5d9c9447f0
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
acp/portal_module.php
View File

@@ -15,7 +15,7 @@ class portal_module
public $new_config = array();
protected $c_class;
protected $db, $user, $cache, $template, $display_vars, $config, $phpbb_root_path, $phpbb_admin_path, $phpEx, $phpbb_container;
protected $root_path, $mod_version_check, $request, $php_ext;
protected $root_path, $version_check, $request, $php_ext;
public $module_column = array();
/** @var \phpbb\di\service_collection Portal modules */
@@ -42,7 +42,7 @@ class portal_module
$this->phpbb_admin_path = $phpbb_admin_path;
$this->php_ext = $phpEx;
$this->phpbb_container = $phpbb_container;
$this->mod_version_check = $this->phpbb_container->get('board3.version.check');
$this->version_check = $this->phpbb_container->get('board3.version.check');
$this->register_modules($this->phpbb_container->get('board3.module_collection'));
define('PORTAL_MODULES_TABLE', $this->phpbb_container->getParameter('board3.modules.table'));
define('PORTAL_CONFIG_TABLE', $this->phpbb_container->getParameter('board3.config.table'));
@@ -166,7 +166,7 @@ class portal_module
else
{
// only show the mod version check if we are on the General Settings page
$this->mod_version_check->version_check();
$this->version_check->version_check();
}
$this->new_config = $this->config;

2
config/services.yml
View File

@@ -30,7 +30,7 @@ services:
- %board3.modules.table%
board3.version.check:
class: board3\portal\includes\mod_version_check
class: board3\portal\includes\version_check
arguments:
- %board3.version_data%
- @config

4
includes/mod_version_check.php → includes/version_check.php
View File

@@ -9,7 +9,7 @@
namespace board3\portal\includes;
class mod_version_check
class version_check
{
/**
* @var array version_data
@@ -42,7 +42,7 @@ class mod_version_check
protected $user;
/**
* Construct a mod_version_check object
* Construct a version_check object
*
* @param array $version_data Version data
* @param \phpbb\config\config $config phpBB config

2
tests/unit/acp/move_module_test.php
View File

@@ -26,7 +26,7 @@ class phpbb_acp_move_module_test extends \board3\portal\tests\testframework\data
$phpbb_container = new \phpbb_mock_container_builder();
// Mock version check
$phpbb_container->set('board3.version.check',
$this->getMockBuilder('\board3\portal\includes\mod_version_check')
$this->getMockBuilder('\board3\portal\includes\version_check')
->disableOriginalConstructor()
->getMock());
// Mock module service collection

2
tests/unit/functions/version_check_test.php
View File

@@ -33,7 +33,7 @@ class phpbb_functions_version_check_test extends \board3\portal\tests\testframew
'NOT_UP_TO_DATE' => 'NOT_UP_TO_DATE',
'UP_TO_DATE' => 'UP_TO_DATE',
));
$this->version_check = new \board3\portal\includes\mod_version_check($version_data, $config, $phpbb_root_path, $phpEx, $this->template, $user);
$this->version_check = new \board3\portal\includes\version_check($version_data, $config, $phpbb_root_path, $phpEx, $this->template, $user);
}
public function test_version_check()